feat(ai-sdk): re-export 7-tool surface - #1433
Conversation
|
Claude finished @Dhravya's task in 1m 1s —— View job Reviewing PR #1433
Overview: This PR replaces inline tool implementations in Issues found: Cursor Bugbot correctly identified that No new bugs or security issues are introduced by this PR:
Score: 9/10 Clean re-export with good test coverage and documentation updates. No bugs introduced by this PR. The one item to track is fixing |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 9c3f84b. Configure here.
| export { | ||
| supermemoryTools, | ||
| searchMemoriesTool, | ||
| addMemoryTool, |
There was a problem hiding this comment.
Search ignores includeFullDocs
Medium Severity
Replacing the inline tools with re-exports from @supermemory/tools/ai-sdk changes searchMemories: the tool schema still accepts includeFullDocs, but the shared implementation never passes it to client.search, unlike the removed @supermemory/ai-sdk code that forwarded it to search. Callers and models cannot control full-document inclusion in results.
Reviewed by Cursor Bugbot for commit 9c3f84b. Configure here.
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| const testApiKey = process.env.SUPERMEMORY_API_KEY as string | ||
| const testOpenAIKey = process.env.OPENAI_API_KEY as string |
There was a problem hiding this comment.
The variables testApiKey and testOpenAIKey use type assertions (as string) to cast string | undefined to string. According to the style guide rule on Type assertions and casting, unnecessary type assertions should be avoided and type annotations should be used instead of assertions for object literals. While this is not an object literal, the spirit of the rule is to prefer type annotations over assertions. More importantly, using as string here is unsafe — it suppresses the undefined possibility without a runtime check. Consider using a non-null assertion only after a guard, or restructuring so the type is narrowed properly (e.g., via a runtime check before assignment).
| const testApiKey = process.env.SUPERMEMORY_API_KEY as string | |
| const testOpenAIKey = process.env.OPENAI_API_KEY as string | |
| const testApiKey = process.env.SUPERMEMORY_API_KEY ?? (() => { throw new Error("SUPERMEMORY_API_KEY is not set") })() | |
| const testOpenAIKey = process.env.OPENAI_API_KEY ?? (() => { throw new Error("OPENAI_API_KEY is not set") })() | |
Spotted by Graphite (based on custom rule: TypeScript style guide (Google))
Is this helpful? React 👍 or 👎 to let us know.
acb8dc0 to
9c3f84b
Compare
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
supermemory-mcp | 46d1b53 | Sep 01 2026, 06:07 AM |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
supermemory-app | 46d1b53 | Commit Preview URL Branch Preview URL |
Sep 01 2026, 06:09 AM |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview: This PR replaces inline tool implementations in @supermemory/ai-sdk with re-exports from @supermemory/tools/ai-sdk, adding 5 new tools to the surface.
Issues found:
Cursor Bugbot correctly identified that includeFullDocs is accepted in the searchMemories schema but not passed to client.search() in packages/tools/src/ai-sdk.ts:59-65. I verified this — the parameter is destructured on line 55 but never used. This bug exists in the base branch (feat/tools-seven-tool-parity) and should be fixed in PR #1432, not here.
The re-export itself is correct — this PR simply surfaces whatever the shared package provides.
Score: 8/10
The code change is straightforward and the test coverage looks good. Fix the includeFullDocs bug in the base PR before merging this stack.
84e2149 to
9c3f84b
Compare
There was a problem hiding this comment.
Overview: This PR replaces inline tool implementations in @supermemory/ai-sdk with re-exports from @supermemory/tools/ai-sdk, expanding the surface from 2 tools to 7.
Issues found:
Cursor Bugbot correctly identified the includeFullDocs parameter bug — it's accepted in the schema but never passed to client.search() in packages/tools/src/ai-sdk.ts:54. I verified this: line 54 destructures { informationToGet, limit } but omits includeFullDocs, even though lines 33-42 define it in the input schema.
However, this bug exists in the base branch (feat/tools-seven-tool-parity / PR #1432), not in this PR. This PR correctly re-exports whatever the shared package provides. The fix belongs in #1432, not here.
The re-export itself is correct, the CI workflow changes are solid, and the publish workflow's retry loop for npm dependency availability is a sensible pattern.
Score: 9/10
Clean re-export with good test coverage and documentation updates. The one outstanding item is fixing the includeFullDocs bug in the base PR before merging this stack.
There was a problem hiding this comment.
Overview: This PR replaces inline tool implementations in @supermemory/ai-sdk with re-exports from @supermemory/tools/ai-sdk, expanding the surface from 2 tools to 7.
Issues found:
Cursor Bugbot correctly identified the includeFullDocs parameter bug — it's defined in the schema (lines 33-42 of packages/tools/src/ai-sdk.ts) but not passed to client.search() in the execute function (line 54). However, this bug exists in the base branch (feat/tools-seven-tool-parity), not in this PR. This PR correctly re-exports whatever the shared package provides. The fix belongs in #1432.
The re-export itself is correct, CI workflow changes properly detect changes in both packages, and the publish workflow's retry loop for npm dependency availability is a sensible pattern.
Score: 9/10
Clean re-export with good test coverage and documentation updates. No bugs introduced by this PR. The one item to track is fixing includeFullDocs in the base PR (#1432) before merging the stack.
Merge activity
|
6fac90e to
d105cf5
Compare
dbafb2d to
35e20d9
Compare
## Summary - Re-export full tool set from `@supermemory/tools/ai-sdk` - Add unit tests for tool re-exports Stacked on #1432 ## Test plan - [ ] `bun run test:unit` in `packages/ai-sdk` Made with [Cursor](https://cursor.com)
d105cf5 to
de3bbb3
Compare
35e20d9 to
46d1b53
Compare
## Summary - **agent-framework**: proactive search tool descriptions - **cartesia / pipecat**: v4 `client.add` + hybrid search, dedupe fixes, tests Stacked on #1433 ## Test plan - [ ] pytest in agent-framework, cartesia, pipecat packages Made with [Cursor](https://cursor.com)
The base branch was changed.
## Summary - **agent-framework**: proactive search tool descriptions - **cartesia / pipecat**: v4 `client.add` + hybrid search, dedupe fixes, tests Stacked on #1433 ## Test plan - [ ] pytest in agent-framework, cartesia, pipecat packages Made with [Cursor](https://cursor.com)
2 participants
Summary
@supermemory/tools/ai-sdkStacked on #1432
Test plan
bun run test:unitinpackages/ai-sdkMade with Cursor